X10 AllOn and AllOff

bkenobi · December 11, 2017, 4:34pm

There was a request to implement the AllOn and AllOff commands correctly in 2016. I went back to the old forum to see if that was ever accomplished, but it looks like the request just sat and died as usual. I was curious if anyone ever implemented the fix for their own setup. It should be really easy to do which makes me wonder why Gene never did it. Basically, HG loops through all modules for a given house code and sends the hail and then On/Off command. Each module takes around 0.5s, so that means the full command takes around 6 seconds. The actual X10 command would be a single pair resulting in a 0.5s response time for ALL modules on the HC. This should be as simple as changing the HG code at the following locations:

github.com

genielabs/x10-lib-dotnet/blob/7237ac14fb475cf19a9fceeff36e139b18772c1c/XTenLib/XTenManager.cs#L458


        });
        string huc = Utility.HouseUnitCodeFromEnum(housecode, unitcode);
        modules[huc].Level = 0.0;
    }
}


/// <summary>
/// Turn on all the light modules with the given housecode.
/// </summary>
/// <param name="houseCode">Housecode.</param>
public void AllLightsOn(X10HouseCode houseCode)
{
    lock (commandLock)
    {
        string hcunit = String.Format("{0:X}{1:X}", (int)houseCode, 0);
        string hcfuntion = String.Format("{0:x1}{1:x1}", (int)houseCode, (int)X10Command.All_Lights_On);
        SendMessage(new byte[] {
            (int)X10CommandType.Address,
            byte.Parse(hcunit, System.Globalization.NumberStyles.HexNumber)
        });
        SendMessage(new byte[] {

github.com

genielabs/x10-lib-dotnet/blob/7237ac14fb475cf19a9fceeff36e139b18772c1c/XTenLib/XTenManager.cs#L481


        });
        // TODO: pick only lights module
        CommandEvent_AllLightsOn(houseCode);
    }
}


/// <summary>
/// Turn off all the light modules with the given housecode.
/// </summary>
/// <param name="houseCode">Housecode.</param>
public void AllUnitsOff(X10HouseCode houseCode)
{
    lock (commandLock)
    {
        string hcunit = String.Format("{0:X}{1:X}", (int)houseCode, 0);
        string hcfuntion = String.Format("{0:x1}{1:x1}", (int)houseCode, (int)X10Command.All_Units_Off);
        SendMessage(new byte[] {
            (int)X10CommandType.Address,
            byte.Parse(hcunit, System.Globalization.NumberStyles.HexNumber)
        });
        SendMessage(new byte[] {

I don’t need the command currently (may never actually), but it seems like this should be done. There’s also a builtin X10 command for AllLightsOn (none for AllLightsOff though). This would also be easy to add.

I don’t know if anyone here is a coder but I thought I’d throw the suggestion out there if anyone wanted an easy way to get your feet wet. David was about the only one I know was submitting a LOT of code and I’m not sure if he’s here.

David_Wallis · December 12, 2017, 2:19pm

If you mean me then I am, but bounz is submitting more than me , I don’t have x10 to test with though.

kevinvinv · December 12, 2017, 2:23pm

I found that the x10 all on and all off works now pretty decent actually. I think I was one of those asking for it back in 2016. As you can see- the comment in the code indicates that R512 or later is necessary for this to work…

Thoughts??

if (module.Is(“AllOnOff”) && parameter.Statistics.Last.Value==0)
{
var DuskToDawn = Modules.InDomain(“HomeAutomation.X10”).WithAddress(“A1”).Get();
Night = (DuskToDawn.Parameter(“Status.Level”).DecimalValue == 1) ;
if (Night) {
Program.Notify(“hello”,“All On”); // display a little pop-up message when this code runs
Program.ApiCall(“HomeAutomation.X10/A/Control.AllLightsOn”); // These commands only work on r512 and later
Program.ApiCall(“HomeAutomation.X10/B/Control.AllLightsOn”);
Program.ApiCall(“HomeAutomation.X10/E/Control.AllLightsOn”);
}
}

bkenobi · December 12, 2017, 2:38pm

I went back and looked again. I was basing the OP on old notes, but it does look as though it sends a direct command now. It doesn’t do all lights on for some reason. And, all lights off would have to be done through the old method as would book keeping for all lights on.

Claton · December 14, 2017, 2:27am

These two web commands work:

http://yourserver/api/HomeAutomation.X10/A/Control.AllLightsOn
http://yourserve/api/HomeAutomation.X10/A/Control.AllLightsOff

I use them with ifttt and my google home.